Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Score readme based on feedback #87

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Updated Score readme based on feedback #87

merged 7 commits into from
Jun 26, 2024

Conversation

sujaya-sys
Copy link
Contributor

@sujaya-sys sujaya-sys commented Jun 26, 2024

We continue to receive feedback on the separation of score specification vs implementation not being quite clear. This PR aims to more transparently differentiate between both i.e. that the core component of Score is the specification while the it is intended that people adopt the spec and build their own implementations.

Copy link
Contributor

@TobiasBabin TobiasBabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good read - LGTM!

@TobiasBabin
Copy link
Contributor

TobiasBabin commented Jun 26, 2024

@sujaya-sys The link checker action is failing, complaining about a non-reachable Google Meet link. That's a false negative though, the link is fine. Have you encountered this before by any chance?

[Edit] I was able to fix the link checker error by adding an exclude for meet.google.com . Apparently that domain is not reachable from the GH runner. Looking good now.

@sujaya-sys
Copy link
Contributor Author

@TobiasBabin thanks yes, the link checker has been complaining about the Google Meet link, I've been meaning to look into it. Thanks so much for fixing it!

@sujaya-sys sujaya-sys merged commit d5ab305 into main Jun 26, 2024
2 checks passed
@sujaya-sys sujaya-sys deleted the clean-up-readme branch June 26, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants