Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow triggering one-off CCC on a block #1043

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

omerfirmak
Copy link

1. Purpose or design rationale of this PR

as per @Thegaram 's request, it might help with incident recovery at some point

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

eth/api.go Show resolved Hide resolved
colinlyguo
colinlyguo previously approved these changes Sep 16, 2024
Thegaram
Thegaram previously approved these changes Sep 17, 2024
eth/api.go Outdated Show resolved Hide resolved
eth/api.go Show resolved Hide resolved
eth/api.go Show resolved Hide resolved
@omerfirmak omerfirmak dismissed stale reviews from Thegaram and colinlyguo via ce6861b September 17, 2024 11:09
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
@omerfirmak omerfirmak merged commit 89639dd into develop Sep 17, 2024
8 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/txpool-remove branch September 17, 2024 15:18
@0xmountaintop 0xmountaintop mentioned this pull request Oct 10, 2024
5 tasks
0xmountaintop pushed a commit that referenced this pull request Oct 10, 2024
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
0xmountaintop added a commit that referenced this pull request Oct 10, 2024
Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants