forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update L2 base fee formula #1053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
previously approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will there be a seperate PR for L1DataFee changes?
Those coefficients need to be updated in the L1GasOracle contract, they are not hard-coded in l2geth. |
omerfirmak
reviewed
Oct 1, 2024
omerfirmak
previously approved these changes
Oct 1, 2024
This reverts commit 8a7d7ff.
omerfirmak
approved these changes
Oct 1, 2024
icemelon
approved these changes
Oct 1, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Oct 9, 2024
* feat: update L2 base fee formula * update 1559 unit test * use current block's base fee in txpool * fix unit test * Revert "use current block's base fee in txpool" This reverts commit 8a7d7ff.
0xmountaintop
added a commit
that referenced
this pull request
Oct 9, 2024
* feat: update L2 base fee formula (#1053) * feat: update L2 base fee formula * update 1559 unit test * use current block's base fee in txpool * fix unit test * Revert "use current block's base fee in txpool" This reverts commit 8a7d7ff. * update `TestCalcBaseFee` * update `TestStateProcessorErrors` --------- Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
Update L2 base fee according to new cost estimates.
One nuance is that geth's codebase uses
misc.CalcBaseFee
in a few places to predict the next block's base fee. In our case this does not work. For example, after deploying this change on the sequencer,CalcBaseFee
will diverge on the sequencer and follower nodes (until they upgrade to a new release). Cases where we usemisc.CalcBaseFee
:Changed in this PR to use the current base fee.Follower nodes might manage txpool following a slightly inaccurate base fee estimation.2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?