fix(api): change gas_price to use pending block

[yiweichi]

1. Purpose or design rationale of this PR

The eth_gasPrice API returns gas price based on latest block, but eth_estimateGas use gas price based on pending block. So if we use the eth_gasPrice API gas price to do an eth_estimateGas API call, there is a possibility it will fail and return max fee per gas less than block base fee. that's because if L1 gas spike and gas-oracle updates the l1BaseFee, the pending block baseFee will be higher than the one based on latest block.
So I think we could change eth_gasPrice API to return gas price based on pending block, that will prevent this issue, and provides a more accurate suggest gas price.

See more details here: https://www.notion.so/scrollzkp/l2geth-returns-wrong-gas-price-issue-1297792d22af8045bbb1e57ff974e6c7

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

• This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change
• Yes

Summary by CodeRabbit

• New Features

  • Enhanced gas price suggestion logic for improved accuracy.
  • Streamlined transaction sending process with clearer method naming.

• Bug Fixes

  • Improved error handling pathways for block retrieval in gas price calculations.

• Chores

  • Incremented patch version from 24 to 25, reflecting updates in the software release.

[coderabbitai]

Walkthrough

The changes in this pull request primarily focus on the GasPrice and SendTransaction methods within the PublicEthereumAPI struct in internal/ethapi/api.go. The GasPrice method's logic is updated to fetch the base fee from a pending block, enhancing error handling. The SignAndSendTransaction method is renamed to SendTransaction, reflecting a shift in API clarity while maintaining the same functionality. Additionally, the VersionPatch constant in params/version.go is incremented from 24 to 25, updating the versioning scheme without altering other logic in the file.

Changes

File	Change Summary
internal/ethapi/api.go	Updated GasPrice method to retrieve base fee from pending block; renamed SignAndSendTransaction to SendTransaction.
params/version.go	Incremented VersionPatch constant from 24 to 25, affecting version output formatting.

Poem

In the code where rabbits hop,
Gas prices rise, they never stop.
With a new name, transactions fly,
Version's up, oh my, oh my!
Hopping through changes, swift and bright,
Code's a dance, a pure delight! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between c88cc48 and 950c75b.

📒 Files selected for processing (2)

• internal/ethapi/api.go (1 hunks)
• params/version.go (1 hunks)

🔇 Additional comments (3)

params/version.go (1)

27-27: LGTM: Version increment follows semantic versioning.

The patch version increment from 24 to 25 is appropriate for a bug fix change, aligning with semantic versioning principles and the PR's scope of fixing the gas price calculation.

internal/ethapi/api.go (2)

71-77: LGTM! The implementation correctly uses pending block for gas price estimation.

The changes align well with the PR objective by:

1. Using pending block instead of latest block for more accurate gas price estimation
2. Properly handling potential errors from block retrieval
3. Adding the base fee only if it exists

This should help prevent transaction failures during L1 gas price spikes.

---

71-77: Verify integration with transaction submission flow.

While the changes look good, it's important to verify that this new gas price estimation works correctly with the transaction submission flow, especially during L1 gas price spikes.

✅ Verification successful

Let me analyze the transaction submission flow further to make a conclusive verification.

---

Gas price estimation changes are properly integrated with transaction flow

The verification shows that:

• Gas price validation is consistently enforced through checkTxFee across all transaction submission paths in internal/ethapi/api.go
• The transaction submission flow properly handles gas price errors and enforces fee caps
• The changes to gas price estimation in the reviewed code are safely integrated with existing validation mechanisms

The modified gas price calculation that includes the base fee is protected by proper error handling and validation, ensuring transaction submission remains reliable even during L1 gas price spikes.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any direct dependencies on eth_gasPrice in transaction submission code
# and verify error handling for gas price estimation failures

# Test 1: Search for eth_gasPrice usage in transaction submission code
echo "Checking eth_gasPrice usage in transaction submission..."
rg -l "eth_gasPrice|GasPrice" --type go

# Test 2: Check for potential error handling patterns around gas price estimation
echo "Checking error handling patterns..."
rg "GasPrice.*error|err.*GasPrice" --type go

Length of output: 4880

---

Script:

#!/bin/bash
# Check the transaction submission flow and gas price integration

# Look for transaction submission code that uses the gas price
echo "Checking transaction submission flow..."
rg -A 5 "func.*SendTransaction" --type go

# Check for gas price validation in transaction processing
echo "Checking gas price validation..."
ast-grep --pattern 'if $_ := checkTxFee($_, $_, $_); $_ != nil {
  $$$
}'

Length of output: 5587

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.