Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): correct default fill values for dask-sparse #1719

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold added this to the 0.10.10 milestone Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (097377c) to head (ebb173d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1719      +/-   ##
==========================================
- Coverage   86.93%   84.45%   -2.49%     
==========================================
  Files          40       40              
  Lines        6039     6039              
==========================================
- Hits         5250     5100     -150     
- Misses        789      939     +150     
Files with missing lines Coverage Δ
src/anndata/_core/merge.py 83.91% <100.00%> (-11.08%) ⬇️

... and 7 files with indirect coverage changes

Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn’t look like we use the test “is a sparse matrix/array or a Dask array containing a sparse matrix/array” anywhere else so I’m not suggesting to make this a helper in this PR yet

@ilan-gold ilan-gold merged commit 96ccce7 into main Oct 17, 2024
14 of 15 checks passed
@ilan-gold ilan-gold deleted the ig/dask_fill_val branch October 17, 2024 13:07
@flying-sheep flying-sheep modified the milestones: 0.10.10, 0.11.0 Oct 17, 2024
@scverse scverse deleted a comment from lumberbot-app bot Oct 17, 2024
@flying-sheep
Copy link
Member

Dask sparse is only in 0.11 right? I modified the milestones under that assumption. If I’m wrong and you want to backport this, please change it back

@ilan-gold
Copy link
Contributor Author

I don't think so, just the API to do i/o is

@ilan-gold ilan-gold modified the milestones: 0.11.0, 0.10.10 Oct 17, 2024
@flying-sheep
Copy link
Member

OK, needs manual backport then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants