Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instance repo (PR 241 -- [pre-commit.ci] pre-commit autoupdate) #95

Closed
wants to merge 2 commits into from
Closed

Update instance repo (PR 241 -- [pre-commit.ci] pre-commit autoupdate) #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b521888
Update instance repo from cookiecutter template
github-actions[bot] Nov 20, 2023
bf1a43c
Update instance repo from cookiecutter template
github-actions[bot] Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ repos:
# https://github.com/jupyterlab/jupyterlab/issues/12675
language_version: "17.9.1"
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.1.5
rev: v0.1.6
hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix]
Expand Down
12 changes: 6 additions & 6 deletions docs/template_usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ You'll notice that the command `git commit` installed a bunch of packages and tr
There is a chance that `git commit -m "first commit"` fails due to the `prettier` pre-commit formatting the file `.cruft.json`. No problem, you have just experienced what pre-commit checks do in action. Just go ahead and re-add the modified file and try to commit again:

```bash
git add -u # update all tracked file
git commit -m "first commit"
git add -u # update all tracked file
git commit -m "first commit"
```

:::
Expand Down Expand Up @@ -247,14 +247,14 @@ Rule categories are selectively enabled by including them under the `select` key

```toml
[tool.ruff]
...
# ...

select = [
"F", # Errors detected by Pyflakes
"E", # Error detected by Pycodestyle
"W", # Warning detected by Pycodestyle
"I", # isort
...
# ...
]
```

Expand All @@ -264,10 +264,10 @@ You can find a long list of checks that this template disables by default sittin

```toml
ignore = [
...
# ...
# __magic__ methods are are often self-explanatory, allow missing docstrings
"D105",
...
# ...
]
```

Expand Down