Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up index_chains #444

Merged
merged 14 commits into from
Nov 1, 2023
Merged

Speed up index_chains #444

merged 14 commits into from
Nov 1, 2023

Conversation

grst
Copy link
Collaborator

@grst grst commented Aug 1, 2023

Closes #386

  • CHANGELOG.md updated
  • Tests added (For bug fixes or new features)
  • Tutorial updated (if necessary)

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (8cc7e73) 81.17% compared to head (3bd4b1b) 80.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   81.17%   80.17%   -1.01%     
==========================================
  Files          49       49              
  Lines        3868     3924      +56     
==========================================
+ Hits         3140     3146       +6     
- Misses        728      778      +50     
Files Coverage Δ
src/scirpy/pp/_index_chains.py 53.70% <83.05%> (-46.30%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@grst grst marked this pull request as ready for review November 1, 2023 15:50
@grst grst enabled auto-merge (squash) November 1, 2023 17:11
@grst grst merged commit 31589c6 into main Nov 1, 2023
9 of 11 checks passed
@grst grst deleted the index-chains-numba branch November 1, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up index_chains
1 participant