Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retreive within_group from mdata OR adata #459

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

grst
Copy link
Collaborator

@grst grst commented Oct 25, 2023

Closes #457

  • CHANGELOG.md updated
  • Tests added (For bug fixes or new features)

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ad45749) 81.19% compared to head (79d7cd1) 81.17%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   81.19%   81.17%   -0.02%     
==========================================
  Files          49       49              
  Lines        3866     3868       +2     
==========================================
+ Hits         3139     3140       +1     
- Misses        727      728       +1     
Files Coverage Δ
src/scirpy/ir_dist/_clonotype_neighbors.py 99.29% <ø> (ø)
src/scirpy/tl/_ir_query.py 93.61% <ø> (ø)
src/scirpy/tl/_clonotypes.py 87.26% <75.00%> (-0.49%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grst grst merged commit 496e4fc into main Oct 25, 2023
9 of 11 checks passed
@grst grst deleted the fix-define-clonotypes-within-group branch October 25, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tl.define_clonotypes within_group parameter returns ValueError
1 participant