Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #454 #465

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Fix #454 #465

merged 2 commits into from
Nov 10, 2023

Conversation

grst
Copy link
Collaborator

@grst grst commented Nov 9, 2023

Closes #454

  • CHANGELOG.md updated
  • Tests added (For bug fixes or new features)

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a75fdc) 80.17% compared to head (62fceba) 80.17%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #465   +/-   ##
=======================================
  Coverage   80.17%   80.17%           
=======================================
  Files          49       49           
  Lines        3924     3924           
=======================================
  Hits         3146     3146           
  Misses        778      778
Files Coverage Δ
src/scirpy/io/_io.py 96.28% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grst grst merged commit 3120a9d into main Nov 10, 2023
11 checks passed
@grst grst deleted the fix-454 branch November 10, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If integer field is None, writing AIRR files fails
1 participant
@grst