Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcrdist draft version implemented #502

Merged
merged 33 commits into from
Apr 21, 2024
Merged

tcrdist draft version implemented #502

merged 33 commits into from
Apr 21, 2024

Conversation

felixpetschko
Copy link
Collaborator

tcrdist draft version implemented

Copy link
Collaborator

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just added a few minor points in the code review.

src/scirpy/ir_dist/__init__.py Outdated Show resolved Hide resolved
src/scirpy/ir_dist/metrics.py Outdated Show resolved Hide resolved
src/scirpy/ir_dist/metrics.py Outdated Show resolved Hide resolved
src/scirpy/ir_dist/metrics.py Outdated Show resolved Hide resolved
src/scirpy/tests/test_ir_dist_metrics.py Outdated Show resolved Hide resolved
src/scirpy/ir_dist/metrics.py Outdated Show resolved Hide resolved
@grst
Copy link
Collaborator

grst commented Apr 17, 2024

Except for the points raised in the code review, all CI checks should pass. If you are stuck somewhere I'm happy to help. I know this can be quite annoying, especially if you haven't done this before.

@grst grst marked this pull request as ready for review April 21, 2024 19:12
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@grst grst merged commit d1db848 into scverse:main Apr 21, 2024
9 checks passed
This was referenced Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants