Skip to content

Commit

Permalink
Backport PR #2637 on branch 1.2.x (chore(external): remove velovi pre…
Browse files Browse the repository at this point in the history
…process functions) (#2638)

Backport PR #2637: chore(external): remove velovi preprocess functions

Co-authored-by: Martin Kim <46072231+martinkim0@users.noreply.github.com>
  • Loading branch information
meeseeksmachine and martinkim0 authored Mar 29, 2024
1 parent 1115032 commit 07b8762
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 97 deletions.
3 changes: 1 addition & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,8 @@ pymde = ["pymde"] # scvi.model.utils.mde dependencies
regseq = ["biopython>=1.81", "genomepy"] # scvi.data.add_dna_sequence
loompy = ["loompy>=3.0.6"] # read loom
scanpy = ["scanpy>=1.6"] # scvi.criticism and read 10x
velovi = ["scvelo>=0.3.0"] # scvi.external.velovi
optional = [
"scvi-tools[autotune,aws,criticism,hub,loompy,pymde,regseq,scanpy,velovi]"
"scvi-tools[autotune,aws,criticism,hub,loompy,pymde,regseq,scanpy]"
] # all optional user functionality

tutorials = [
Expand Down
3 changes: 1 addition & 2 deletions scvi/external/velovi/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from ._model import VELOVI
from ._module import VELOVAE
from ._utils import get_permutation_scores, preprocess_data

__all__ = ["VELOVI", "VELOVAE", "get_permutation_scores", "preprocess_data"]
__all__ = ["VELOVI", "VELOVAE"]
80 changes: 0 additions & 80 deletions scvi/external/velovi/_utils.py

This file was deleted.

13 changes: 0 additions & 13 deletions tests/external/velovi/test_velovi.py
Original file line number Diff line number Diff line change
@@ -1,20 +1,7 @@
import scvelo as scv

from scvi.data import synthetic_iid
from scvi.external.velovi import VELOVI


def test_preprocess_data():
adata = synthetic_iid()
adata.layers["spliced"] = adata.X.copy()
adata.layers["unspliced"] = adata.X.copy()
scv.pp.normalize_per_cell(adata)
scv.pp.log1p(adata)
scv.pp.moments(adata, n_pcs=30, n_neighbors=30)
# TODO(adamgayoso): use real data for this test
# preprocess_data(adata)


def test_velovi():
n_latent = 5
adata = synthetic_iid()
Expand Down

0 comments on commit 07b8762

Please sign in to comment.