improvement(results): add limit lines to graphs #476
+300
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
our most complex example*: *It won't be visible yet like that on prod, due |
soyacz
force-pushed
the
add-reference-line-to-grahps
branch
from
b030666
to
b8b773a
Compare
Added limit lines to graphs based on best results and validation rules. When creating graphs, for each point limit is calculated and plotted (also visible in the tooltip). Have in mind that limits might differ from ones in "Results" tab as client might ignore rules (which most of our test cases currently do). closes: scylladb/qa-tasks#1763
soyacz
force-pushed
the
add-reference-line-to-grahps
branch
from
b8b773a
to
0edb2f4
Compare
|
As per discussion today with @fruch , I made it to print only one limit line if 'fixed limit' is set (as it is the same for all the series). |
k0machi
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added limit lines to graphs based on best results and validation rules. When creating graphs, for each point limit is calculated and plotted (also visible in the tooltip).
Have in mind that limits might differ from ones in "Results" tab as client might ignore rules (which most of our test cases currently do).
closes: https://github.com/scylladb/qa-tasks/issues/1763