improvement(results): exclude ignored results from graphs #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes results might be wrong (e.g. wrong job configuration) leading to results that outstand and being irrelevant or updating best result value causing validation to break. If job investigation status is set to `IGNORED` make Argus to skip plotting it and exclude from best results map. closes: scylladb#462
soyacz
force-pushed
the
remove-ignored-job-results-from-graph
branch
from
b2fad9f
to
7e33f4a
Compare
fruch
reviewed
Oct 15, 2024
| @@ -197,6 +198,17 @@ class ResultsService: | |||
| def __init__(self): | |||
| self.cluster = ScyllaCluster.get() | |||
|
|
|||
| @cache | |||
| def _ignored_results(self, test_id: UUID) -> list[str]: | |||
There was a problem hiding this comment.
When is this cache gonna be cleared ?
When Argus restarts ?
There was a problem hiding this comment.
no, it's per request - will be needed when we merge PR with drawing limit lines, where best results are also used, to avoid double query db.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes results might be wrong (e.g. wrong job configuration) leading to results that outstand and being irrelevant or updating best result value causing validation to break.
If job investigation status is set to
IGNOREDmake Argus to skip plotting it and exclude from best results map.closes: #462