improvement(results): respond with error when result failed #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires a change in SCT to handle possible error and act accordingly (raise error event, so later test is failed). |
In case there is a cell with 'ERROR' status, then respond with `error` status, so client may take proper action based on it (e.g. marking test as failed). refs: scylladb/qa-tasks#1765
soyacz
force-pushed
the
fail-test-based-on-results
branch
from
17cf26b
to
4ac625c
Compare
|
this one should be merged after scylladb/scylla-cluster-tests#9011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there is a cell with 'ERROR' status, then respond with
errorstatus, so client may take proper action based on it (e.g. marking test as failed).refs: https://github.com/scylladb/qa-tasks/issues/1765