Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retract tags taken by mistake from kiwicom/gocql #139

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

avelanarius
Copy link

@avelanarius avelanarius commented Jul 20, 2023

Retract v1.8.0, v1.8.1, v1.9.0, v1.10.0 - tags mistakenly taken from kiwicom/gocql, which are not actual releases made in scylladb/gocql.

Even though those tags were removed from scylladb/gocql (see #110), some Go module mirrors have already fetched them:

$ go list -m --versions github.com/scylladb/gocql
github.com/scylladb/gocql v1.0.0 v1.0.1 v1.0.2 v1.0.3 v1.0.4 v1.1.0 v1.2.0 v1.2.1 v1.3.0-rc.1 v1.3.0 v1.3.1 v1.3.2 v1.3.3 v1.3.4 v1.4.0 v1.4.1 v1.4.2 v1.4.3 v1.5.0 v1.6.0 v1.7.0 v1.7.1 v1.7.2 v1.7.3 v1.8.0 v1.8.1 v1.9.0 v1.10.0

As we can't control those mirrors, they will always return an incorrect version of gocql, even if we release "new" v1.9.0, v1.10.0.

Subsequent to merging of this patch, version v1.11.0 of scylladb/gocql will be released.

Fixes #132

@avelanarius avelanarius requested review from piodul and zimnx July 20, 2023 15:21
@avelanarius
Copy link
Author

Before merging this and doing the release, I'll also do a dry run on my fork (avelanarius/gocql) to double check that retractions are working correctly.

Retract v1.8.0, v1.8.1, v1.9.0, v1.10.0 - tags mistakenly taken from
kiwicom/gocql, which are not actual releases made in scylladb/gocql.

Even though those tags were removed from scylladb/gocql (see scylladb#110),
some Go module mirrors have already fetched them:

  $ go list -m --versions github.com/scylladb/gocql
  github.com/scylladb/gocql v1.0.0 v1.0.1 v1.0.2 v1.0.3 v1.0.4 v1.1.0 v1.2.0 v1.2.1 v1.3.0-rc.1 v1.3.0 v1.3.1 v1.3.2 v1.3.3 v1.3.4 v1.4.0 v1.4.1 v1.4.2 v1.4.3 v1.5.0 v1.6.0 v1.7.0 v1.7.1 v1.7.2 v1.7.3 v1.8.0 v1.8.1 v1.9.0 v1.10.0

As we can't control those mirrors, they will always return an incorrect
version of gocql, even if we release "new" 1.9.0, 1.10.0.

Subsequent to merging of this patch, version v1.11.0 of scylladb/gocql
will be released.
@avelanarius
Copy link
Author

Successfully finished the "dry run" on my fork - tagged some commits as v1.8.0, v1.9.0, ... and tagged this retraction commit as v1.11.0. After creating this go.mod:

module example/user/hello

require (
        github.com/gocql/gocql v1.2.1
)

replace github.com/gocql/gocql => github.com/avelanarius/gocql v1.10.0

go 1.20

Go properly sees this older version as retracted:

go list -m -u all
example/user/hello
github.com/bitly/go-hostpool v0.0.0-20171023180738-a3a6125de932 [v0.1.0]
github.com/bmizerany/assert v0.0.0-20160611221934-b7ed37b82869
github.com/davecgh/go-spew v1.1.1
github.com/gocql/gocql v1.2.1 (retracted) [v1.5.2] => github.com/avelanarius/gocql v1.10.0 (retracted) [v1.11.0]

@avelanarius avelanarius merged commit 8c8fbcc into scylladb:master Jul 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find the scyllacloud import
2 participants