Update golangci-lint in Makefile and CI and turn it on in CI #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/fix-golangci-lint
branch
11 times, most recently
from
0db4f38
to
f059df5
Compare
Comment on lines
-30
to
-32
| // Cache memory for a rows during iteration in structScan. | ||
| fields [][]int | ||
| values []interface{} |
There was a problem hiding this comment.
Are we okay with losing the information that this comment gives?
There was a problem hiding this comment.
thanks for pointing out, fixed.
batchx.go
Outdated
| @@ -4,6 +4,7 @@ import ( | |||
| "github.com/gocql/gocql" | |||
| ) | |||
|
|
|||
| // Batch a batch operations. | |||
There was a problem hiding this comment.
I don't quite get this comment
There was a problem hiding this comment.
Added something that makes more sense
dkropachev
force-pushed
the
dk/fix-golangci-lint
branch
from
f059df5
to
d64fcd7
Compare
sylwiaszunejko
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes.
Update
golangci-lint, add it to github workflow, address all linter complaints.