-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors: remove ParseError #1054
errors: remove ParseError #1054
Commits on Sep 23, 2024
-
f_errors: QueryParametersSerializationError
Introduced an error type returned by QueryParameters::serialize.
Configuration menu - View commit details
-
Copy full SHA for b3738e0 - Browse repository at this point
Copy the full SHA b3738e0View commit details -
f_errors: QuerySerializationError
Introduced an error type to give more context for errors returned by Query::serialize.
Configuration menu - View commit details
-
Copy full SHA for ff66c0d - Browse repository at this point
Copy the full SHA ff66c0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f274de - Browse repository at this point
Copy the full SHA 7f274deView commit details -
f_errors: PrepareSerializationError
Introduced an error type to give more context for errors returned by Prepare::serialize.
Configuration menu - View commit details
-
Copy full SHA for 4d0262f - Browse repository at this point
Copy the full SHA 4d0262fView commit details -
f_errors: BatchSerializationError
Introduced an error type to give more context for errors returned by Batch::serialize.
Configuration menu - View commit details
-
Copy full SHA for cc6be0f - Browse repository at this point
Copy the full SHA cc6be0fView commit details -
f_errors: AuthResponseSerializationError
Introduced an error type to give more context for errors returned by AuthResponse::serialize.
Configuration menu - View commit details
-
Copy full SHA for df703bd - Browse repository at this point
Copy the full SHA df703bdView commit details -
f_errors: RegisterSerializationError
Introduced an error type to give more context for errors returned by Register::serialize.
Configuration menu - View commit details
-
Copy full SHA for 24cefd0 - Browse repository at this point
Copy the full SHA 24cefd0View commit details -
f_errors: StartupSerializationError
Introduced an error type to give more context for errors returned by Startup::serialize.
Configuration menu - View commit details
-
Copy full SHA for f597865 - Browse repository at this point
Copy the full SHA f597865View commit details -
f_errors: CqlRequestSerializationError
Introduced an error type to be returned by an implementations of SerializableRequest trait.
Configuration menu - View commit details
-
Copy full SHA for 33b8472 - Browse repository at this point
Copy the full SHA 33b8472View commit details
Commits on Sep 25, 2024
-
f_errors: encapsulate snap errors
Replace `FrameError::Frame(De)compression` variants which give no additional context with errors returned from snap library. Notice that we do not want to introduce `snap::Error` type to public API in case we ever want to bump snap library version in the future. This is why we provide additional context with Arc<dyn Error>.
Configuration menu - View commit details
-
Copy full SHA for 7cb971b - Browse repository at this point
Copy the full SHA 7cb971bView commit details -
f_errors: remove lz4 compression error variant
lz4 compression cannot fail in our case, and so we never return the error variant with lz4 compression failure.
Configuration menu - View commit details
-
Copy full SHA for 87dbcde - Browse repository at this point
Copy the full SHA 87dbcdeView commit details -
f_errors: extract serialization errors from FrameError
The most important thing is that we narrow the return error type of SerializedRequest::make from FrameError to CqlRequestSerializationError. We remove both `CqlRequestSerializationError` and `SnapCompressError` variants from FrameError. `SnapCompressError` variant is now moved to `CqlRequestSerializationError`.
Configuration menu - View commit details
-
Copy full SHA for 706b81e - Browse repository at this point
Copy the full SHA 706b81eView commit details -
f_errors: remove ParseError from FrameError
Replaced FrameError::Parse with multiple variants which provide more context.
Configuration menu - View commit details
-
Copy full SHA for 959b8b1 - Browse repository at this point
Copy the full SHA 959b8b1View commit details -
f_errors: replace StdIoError with variants
Added more context to std::io::Errors in FrameDeserializationError.
Configuration menu - View commit details
-
Copy full SHA for a84edb2 - Browse repository at this point
Copy the full SHA a84edb2View commit details -
f_errors: FrameHeaderParseError
This is a new error type returned from frame::read_response_frame. We extracted FrameError variants that were originally constructed there, and moved them to new error type.
Configuration menu - View commit details
-
Copy full SHA for 0af67b8 - Browse repository at this point
Copy the full SHA 0af67b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21dc0b7 - Browse repository at this point
Copy the full SHA 21dc0b7View commit details -
scylla-cql: remove lz4_flex DecompressError from public API
lz4_flex crate is unstable - we need to replace the direct usage of this type with `Arc<dyn Error>`.
Configuration menu - View commit details
-
Copy full SHA for 9a79987 - Browse repository at this point
Copy the full SHA 9a79987View commit details -
f_errors: make FrameBodyExtensionsParseError clonable
We ultimately want to include FrameBodyExtensionsParseError in QueryError, which needs to be clonable.
Configuration menu - View commit details
-
Copy full SHA for 6039ded - Browse repository at this point
Copy the full SHA 6039dedView commit details -
errors: wrap FrameBodyExtensionsParseError in QueryError
Until now, the FrameErrors were stringified. This commit changes that.
Configuration menu - View commit details
-
Copy full SHA for faa3a93 - Browse repository at this point
Copy the full SHA faa3a93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 777ccb0 - Browse repository at this point
Copy the full SHA 777ccb0View commit details -
errors: remove unused CqlTypeError
This error type is not constructed anywhere. It can be removed.
Configuration menu - View commit details
-
Copy full SHA for 9db7eca - Browse repository at this point
Copy the full SHA 9db7ecaView commit details -
f_errors: remove unused ParseError variants
Because of the previous changes, there were some unused ParseError variants which we can get rid of. This cleans up a bit, and helps us to see what variants are actually used and need to be removed later.
Configuration menu - View commit details
-
Copy full SHA for e609444 - Browse repository at this point
Copy the full SHA e609444View commit details -
request: introduce RequestDeserializationError
ParseError was abused in testing as well. DeserializableRequest is a trait mainly used by `scylla-proxy`. Previously, it returned `ParseError`. This commit introduces a new error type, designed for this specific case. It does not provide much context, as it is not intended to be used by the users.
Configuration menu - View commit details
-
Copy full SHA for 857fc06 - Browse repository at this point
Copy the full SHA 857fc06View commit details -
LegacySerValues: remove unused test util function
This function is not used anywhere. It contains the last usage of `std::io::Error` -> `ParseError` mapping. Let's get rid of that.
Configuration menu - View commit details
-
Copy full SHA for e69d9f7 - Browse repository at this point
Copy the full SHA e69d9f7View commit details -
f_errors: remove io error variant from ParseError
It is not used anymore. We got rid of yet another variant from ParseError.
Configuration menu - View commit details
-
Copy full SHA for 50180d0 - Browse repository at this point
Copy the full SHA 50180d0View commit details -
f_errors: remove TryFromInt to ParseError conversion
We removed last usages of this conversion from scylla-proxy. This allows us to remove the From impl.
Configuration menu - View commit details
-
Copy full SHA for 4482a24 - Browse repository at this point
Copy the full SHA 4482a24View commit details -
f_errors: remove BadIncomingData from ParseError
We remove last usage (an impl) of this variant. This variant was the most awful, since it stringified many errors. We fortunately can remove it now.
Configuration menu - View commit details
-
Copy full SHA for f7585f6 - Browse repository at this point
Copy the full SHA f7585f6View commit details -
f_errors: remove LLDeserError from ParseError
Removed last usages of ParseError from scylla-proxy. This allows us to remove LowLevelDeserializationError variant from ParseError.
Configuration menu - View commit details
-
Copy full SHA for 2ea9b45 - Browse repository at this point
Copy the full SHA 2ea9b45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 418c5ed - Browse repository at this point
Copy the full SHA 418c5edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62c661b - Browse repository at this point
Copy the full SHA 62c661bView commit details