Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: blink on dark theme #1260

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: blink on dark theme #1260

wants to merge 2 commits into from

Conversation

dgarcia360
Copy link
Collaborator

Closes #1218

Hides the html main component until the theme mode is resolved.

How to test

  1. Clone the PR.
  2. Build the docs and open the URL in incognito mode or clean cache.
  3. Navigate between pages. It shouldn't blink.

@annastuchlik
Copy link
Collaborator

@dgarcia360 I've checked 25+ pages, and most of them behaved as expected. However, two or three pages did blink (in incognito, with clean cache), but it's hard to define a rule on which ones did.
My suggestion would be to merge this PR and check the behavior on other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annastuchlik annastuchlik annastuchlik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brief flash of light mode when navigating between pages in dark mode
2 participants
@dgarcia360 @annastuchlik