-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
World knowledge tests #126
World knowledge tests #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
I have some high-level suggestions, in addition to / to summarize the inline comments:
- I just realized that
apply_resolution_strategy
doesn't actually use the world argument? We can remove it. - Add docstrings to each test function explaining what is being tested
- Check out my comment on using
pytest.raises
-- will save a lot of lines of code - Instead of using
Pose.from_list()
just use the regular constructor with named arguments, e.g.Pose(x=1.0, y=2.0, yaw=np.pi/2)
Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
@sea-bass made all the changes except the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome -- thanks @henrygerardmoore!
assert ( | ||
entity.category == "banana" | ||
and entity.parent.category == "table" | ||
and entity.parent.parent.parent.name == "kitchen" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried locally and it worked great for me...
You can either just do pip install pytest-assume
in your existing environment, or if you add it to the requirements file you'll need to rerun the entire setup/create_python_env.bash
.
... but like, this doesn't matter for this PR -- it was just an out there suggestion. I'll let you follow up in another if you care!
Added world knowledge tests. Not entirely sure if this is a good format or if we want more or different kinds of tests, feel free to ask for any of that! This is my first time making python tests so it will be a learning experience
Resolves #99