Added screenreader text on close button #1672
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slider storybook for react now shows label and sublabel, along with default value and a big number example.
🦋 Changeset statusBased on the included changeset, the following releases will be published as a result of this PR:
Note: If unpublished changesets where merged to |
|
👋 Thanks for creating a pull request! 🚀 Checkout the storybooks we've created for it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added screen reader text on close button.
Connected to this issue: #706 & #665
Please check if you also get visual error on AlertRibbon close button on colored backgrounds in React:
https://storybook.seb.io/latest/react/?path=/docs/components-alertribbon--docs
Locally it looks like this line is not triggered anymore:
green\libs\chlorophyll\scss\components\alert-ribbon_mixins.scss
line 139 - background-color: var(--color);
Also green\libs\react\src\lib\card\card.stories.tsx file shows up as red/error?