Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves compatible with PB size storage file and Linux CentOS 7 commands including iscsiadm, parted, fdisk, mkfs.* #43

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ActiveVolcano
Copy link

1. Fix redundant one block capacity

After login jSCSI target via the Linux bundled iSCSI initiator command iscsiadm,
fdisk -l reports capacity with one redundant block (512 bytes), e.g.

Disk /dev/sdd: 10000.0 GB, 10000000000512 bytes, 19531250001 sectors

and jSCSI logs error messages about read / write address out of range.
All of above are caused by jSCSI target returning wrong capacity value.

This pull request fix it,
and also fix #8 for the same cause.

2. Add Unit Serial Number page into INQUIRY command

After login jSCSI target via the Linux bundled iSCSI initiator command iscsiadm,
jSCSI logs error messages about illegal INQUIRY request like

ERROR o.j.t.connection.stage.fullfeature.InquiryStage - illegal INQUIRY request
ERROR o.j.t.connection.stage.fullfeature.InquiryStage - CDB bytes:
0x12   0x01   0x80   0x00
0xfe   0x00   0x00   0x00
0x00   0x00   0x00   0x00
0x00   0x00   0x00   0x00

which is an Unit Serial Number page INQUIRY request,
added support by this pull request.

3. Support PB size storage file as target

This pull request adds iSCSI commands READ (16), READ (12), WRITE (16), WRITE (12) to jSCSI target module,
so that PB size file can be used as storage.
It works under Linux CentOS 7 with the bundled commands iscsiadm, parted, fdisk, mkfs.*

4. Support Linux parted command

Linux CentOS 7 bundled command parted aborts with error
because lack of REPORT SUPPORTED OPERATION CODES in jSCSI target,
which is fixed by this pull request.

5. Enrich README

  • How to build
  • Markdown head format compatible with GitHub

@ActiveVolcano ActiveVolcano marked this pull request as ready for review July 29, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read Capacity reports total # of blocks, not address of last block
2 participants