-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Serbian translation #445
Conversation
Hello, @lxmarinkovic I'm happy to see that you created whole Serbian translation. I've made few improvements, so feel free to give your opinion about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rammba
LGTM, thanks for taking part in this improvement.
Just one minor edit to keep consistency, if you don't mind:
kompatibilni regularni izrazi
to
Compatible Regular Expressions
primarily because of the acronym
Nice catch, thanks for the suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀🖖
Hi, @JohnTitor ; when you get time pls, review and merge :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
PR Checklist
spec
dir.npm run lint
.TRANSLATORS.md
.