Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Serbian translation #445

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Improve Serbian translation #445

merged 3 commits into from
Jul 28, 2024

Conversation

rammba
Copy link
Contributor

@rammba rammba commented May 13, 2024

PR Checklist

  • This PR doesn't modify the files in the spec dir.
  • This PR passes npm run lint.
  • (Optional) If you're willing to help reviews about your language's translations, add your name to the TRANSLATORS.md.

@rammba
Copy link
Contributor Author

rammba commented May 13, 2024

Hello, @lxmarinkovic I'm happy to see that you created whole Serbian translation. I've made few improvements, so feel free to give your opinion about it.

Copy link
Contributor

@lxmarinkovic lxmarinkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rammba
LGTM, thanks for taking part in this improvement.
Just one minor edit to keep consistency, if you don't mind:
kompatibilni regularni izrazi
to
Compatible Regular Expressions
primarily because of the acronym

@rammba
Copy link
Contributor Author

rammba commented May 15, 2024

Nice catch, thanks for the suggestion.

Copy link
Contributor

@lxmarinkovic lxmarinkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🖖
Hi, @JohnTitor ; when you get time pls, review and merge :D

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor closed this Jul 27, 2024
@JohnTitor JohnTitor reopened this Jul 27, 2024
@JohnTitor JohnTitor merged commit 51afa94 into semver:gh-pages Jul 28, 2024
1 check passed
@rammba rammba deleted the fix/serbian branch September 15, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants