-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Unable to read data on windows. Fixes #29 #94
base: main
Are you sure you want to change the base?
Commits on Feb 23, 2022
-
Restructure into stdlib like "sys" mod for impl.
Change SerialPort to a struct, and move the implementation to a "sys" module which selects between different possible "real" implementations.
Configuration menu - View commit details
-
Copy full SHA for 295b329 - Browse repository at this point
Copy the full SHA 295b329View commit details -
Move posix-specific features to an extension.
Add a public posix module containing a posix-specific SerialPortExt trait and the BreakDuration type.
Configuration menu - View commit details
-
Copy full SHA for 1c66f32 - Browse repository at this point
Copy the full SHA 1c66f32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09174fc - Browse repository at this point
Copy the full SHA 09174fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 16bcb54 - Browse repository at this point
Copy the full SHA 16bcb54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f82827 - Browse repository at this point
Copy the full SHA 7f82827View commit details -
Get the windows build working. Remove the windows-specific extensions module because windows doesn't have any methods not available on posix.
Configuration menu - View commit details
-
Copy full SHA for c2982c1 - Browse repository at this point
Copy the full SHA c2982c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b04ade - Browse repository at this point
Copy the full SHA 3b04adeView commit details -
Use as_ref with manual deref instead of as_deref.
One of the CI toolchains uses an older version of rustc, which doesn't include as_deref, so we just do the same thing that as_deref does internally.
Configuration menu - View commit details
-
Copy full SHA for 5cdd829 - Browse repository at this point
Copy the full SHA 5cdd829View commit details -
Move impl of SerialPortExt to the posix ext mod.
Implementing the extension in the posix extension mod ensures it will appear in documentation even if documentation is built on windows, since that mod is cfg(doc).
Configuration menu - View commit details
-
Copy full SHA for 12c41be - Browse repository at this point
Copy the full SHA 12c41beView commit details -
Current timeouts are based on [this comment from !78](https://gitlab.com/susurrus/serialport-rs/-/merge_requests/78#note_343695538), copying the windows timeout settings needed to get posix-like timeout behavior. That is, reads should return available data ASAP regardless of timeouts, but stop early when there is a timeout.
Configuration menu - View commit details
-
Copy full SHA for 32612b8 - Browse repository at this point
Copy the full SHA 32612b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a80f33d - Browse repository at this point
Copy the full SHA a80f33dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5923ec0 - Browse repository at this point
Copy the full SHA 5923ec0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 934539e - Browse repository at this point
Copy the full SHA 934539eView commit details -
Add EventCache for win event HANDLEs.
EventCache will hold the HANDLE for a read/write when not in use or will produce a new handle for each thread when multiple threads try to read/write at the same time. The cache holds a single value and will deallocate extra handles when there is already a handle stored. We have one cache for a read_handle and one cache for a write_handle. The expectation is that in the normal case, at most one thread will be reading/writing at a time, and so at most one handle will be created for each of read and write. But in abnormal cases, when multiple threads try to read/write at the same time, we auto-create and auto-close extra handles as needed. Fix the into_raw_handle/into_raw_fd to drop other fields that were previously leaked.
Configuration menu - View commit details
-
Copy full SHA for bb0becd - Browse repository at this point
Copy the full SHA bb0becdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d83eca - Browse repository at this point
Copy the full SHA 6d83ecaView commit details -
Configuration menu - View commit details
-
Copy full SHA for cfda6e0 - Browse repository at this point
Copy the full SHA cfda6e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffd958b - Browse repository at this point
Copy the full SHA ffd958bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d3a17f - Browse repository at this point
Copy the full SHA 4d3a17fView commit details
Commits on Apr 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 310ab9c - Browse repository at this point
Copy the full SHA 310ab9cView commit details