Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you hit Ctrl+C, the underlying rspec tests might continue to still run. This behaviours seemed to consistently happen in my environment (executed via
bundle exec
).This PR adopts logic similar to parallel_tests that fixes this: https://github.com/grosser/parallel_tests/blob/6e9be6f529b64e5f9c8e4439754bca0b2ef3f2b1/lib/parallel_tests/cli.rb#L31-L54
An extra consideration for
turbo_tests
was that the Ctrl+C might happen before the FIFO file was written to, causing the read thread to block indefinitely. A fix for this is to make the process exit monitoring thread write to the FIFO file (if not already written to) to signal the other thread to stop.