Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug where messages from frameId 0 weren't having sender.frameId set #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gurupras
Copy link
Contributor

@gurupras gurupras commented Jul 14, 2022

A value of 0 for frameId is valid. However, the existing code was skipping this due to a truthiness check. This has been replaced with an explicit frameId === undefined check instead.

@zikaari
Copy link
Collaborator

zikaari commented Sep 27, 2022

Hi @gurupras, can you please re-visit this against the next branch in this repo to see how things are behaving?

@zikaari
Copy link
Collaborator

zikaari commented Nov 14, 2022

@gurupras checking in if you were able to test next branch, available on NPM as webext-bridge@6.0.0-rc4?

@@ -109,7 +109,7 @@ function initIntercoms() {

const portFrame = incomingPort.sender.frameId

if (portFrame)
if (portFrame !== undefined)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would allow nulls to pass this check. Should this be portFrame || portFrame === 0 instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants