onionreq: reject truncated XChaCha20 ciphertexts - #140
Open
Ap4sh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
HopEncryption::decrypt_xchacha20()currently extracts the 24-byte nonce before checking the ciphertext length, while the existing check only requires the 16-byte authentication taginputs shorter than the nonce violate the
std::span::subspan()precondition, and inputs between 24 and 39 bytes underflow the plaintext sizethis validates the full nonce + tag minimum before slicing and keeps the legacy AES response fallback unchanged
tests
./Build/tests/testAll "[onionreq]" --colour-mode nonevalgrind --quiet --error-exitcode=99 --leak-check=full ./Build/tests/testAll "Onion request encryption" --colour-mode none./Build/tests/testAll --colour-mode none./Build/tests/testLogging --colour-mode none./utils/format.sh verify