Set REMOTE_ADDR in HTTP request event payload #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devurandom
force-pushed
the
devurandom-patch-1
branch
from
3709c15
to
cbc098f
Compare
The Sentry event payload supports `REMOTE_ADDR` under the `env` key: * https://develop.sentry.dev/sdk/event-payloads/request/ * https://develop.sentry.dev/sdk/event-payloads/types/#request The `:remote-addr` key can be added to ring requests using `ring.middleware.proxy-headers` from `ring/ring-headers:0.3.0` that is e.g. enabled with `(ring-defaults/wrap-defaults ,,, {:proxy true})` from `ring/ring-defaults:0.3.4`. If `:remote-addr` is not present in the request, we send the empty string and Sentry will not show this field in its web UI.
devurandom
force-pushed
the
devurandom-patch-1
branch
from
cbc098f
to
f4e7a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sentry event payload supports
REMOTE_ADDRunder theenvkey:The
:remote-addrkey can be added to ring requests usingring.middleware.proxy-headersfromring/ring-headers:0.3.0that ise.g. enabled with
(ring-defaults/wrap-defaults ,,, {:proxy true})fromring/ring-defaults:0.3.4.If
:remote-addris not present in the request, we send the empty stringand Sentry will not show this field in its web UI.