Add new features in module #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add feature git-prompt; Add feature set fg, bg colors and styles of present working directory; Rewrite templates/colorprompt.erb.
|
Wow, that's an awesome addition to the module. I'm on summer vacation right now, but I'll test it and merge it in as soon as I'm back. Thank you so much! |
|
Thank you. I waiting for you. Have fun in summer vacation. |
manifests/init.pp
Outdated
| fail('Value of parameter $custom_usercolors must be not empty!') | ||
| } else { | ||
| if ( versioncmp($::puppetversion, '4.0.0') >= 0 ) { | ||
| $custom_usercolors.each | $user, $colors | { |
There was a problem hiding this comment.
@MemberIT I'm getting a syntax error on this line with Puppet version 3.7.2.
Error: Syntax error at '.'; expected '}' at /etc/puppet/modules/colorprompt/manifests/init.pp:169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation fg, bg colors and styles (function validate_colors):
Added validation function of input params.
Add feature git-prompt
Add feature set fg, bg colors and styles of present working directory
Rewrite templates/colorprompt.erb:
Now template easier.
Update README
P.S. I'm sorry for a lot of changes on one commit.
P.P.S. Sorry for my English.