Skip to content

Commit

Permalink
fix(http): Fix "Failed sending data to the peer" errors
Browse files Browse the repository at this point in the history
Upgrading curl fixes errors like "Failed sending data to the peer" flooding the
log.  This is described upstream in curl/curl#10591
and fixed in curl 8.2.0.  Here we upgrade to curl 8.9.1 (latest as of today).
  • Loading branch information
joeyparrish committed Oct 24, 2024
1 parent ed68e69 commit d721d05
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packager/file/http_file.cc
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ void HttpFile::SetupRequest() {
curl_easy_setopt(curl, CURLOPT_POST, 1L);
break;
case HttpMethod::kPut:
curl_easy_setopt(curl, CURLOPT_PUT, 1L);
curl_easy_setopt(curl, CURLOPT_UPLOAD, 1L);
break;
}

Expand Down
2 changes: 1 addition & 1 deletion packager/third_party/curl/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,5 @@ add_subdirectory(source)
# Our enabling of c-ares doesn't automatically set a dependency between libcurl
# and c-ares. Fix that now.
if(USE_ARES)
target_link_libraries(libcurl c-ares)
target_link_libraries(libcurl_static PUBLIC c-ares)
endif()
2 changes: 1 addition & 1 deletion packager/third_party/curl/source
Submodule source updated 4675 files

0 comments on commit d721d05

Please sign in to comment.