-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cmake port of Media crypto #1221
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
09017fc
to
387fe43
Compare
@cosmin, could you fix the linter errors? To run the linter against the changes since your local python3 packager/tools/git/check_formatting.py cmake To fix the same errors, run: git clang-format --style Chromium cmake For both of those, make sure your local Thanks! |
387fe43
to
e93d6fa
Compare
…to avoid windows errors
Now that I reverted the change with dealt with calling |
ok, I think this is an example of a callsite that sets up the cipher text buffer to be the same size as the plaintext, but when using |
@joeyparrish take a look at the most recent commit, the only way I could think to workaround this issue is to introduce a function to return the expected ciphertext size so the caller can allocate a properly sized buffer for it. Open to suggestions though if there's a better way to solve this. |
ffe639d
to
9c60090
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such an improvement, thanks!
9c60090
to
e83abde
Compare
I have now fixed the HTTP tests, so I'm going to merge your branch with |
Build failure on Windows:
That sounds like it could be a real bug. |
As far as I can tell this code has not changed recently. I don't think it's a bug in this case because by the time
happens which shadows the frame function parameter it was already parsed into
however it's trivial to fix while I'm at it. |
All tests seem to pass now except for Arch which should be fixed by #1233 |
Rebasing #1148 on top of current cmake branch
Related to #1047