Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix NPM binary publication #1371

Merged
merged 2 commits into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/publish-npm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ jobs:
uses: actions/checkout@v4
with:
ref: ${{ inputs.tag }}
submodules: recursive

- uses: actions/setup-node@v4
with:
Expand Down
8 changes: 8 additions & 0 deletions npm/.npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# This file is required for us, even if empty.
#
# The default .npmignore would disallow bin/, which contains binaries for our
# NPM release. Every release before v3.0.3 was missing .npmignore, and
# therefore had no binaries. These were unusable in NPM, and have been marked
# as deprecated because of it.
#
# See also https://github.com/shaka-project/shaka-packager/issues/1369
1 change: 1 addition & 0 deletions npm/prepublish.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ var commandNames = {
},
darwin: {
'x64': 'packager-osx-x64',
'arm64': 'packager-osx-arm64',
},
win32: {
'x64': 'packager-win-x64.exe',
Expand Down
Loading