Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set yuv full range flag to 1 for VP9 with sRGB #1398

Merged
merged 2 commits into from
May 11, 2024
Merged

fix: set yuv full range flag to 1 for VP9 with sRGB #1398

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e71a84
fix: set yuv full range flag to 1 for VP9 with sRGB
cosmin May 9, 2024
34c9e4b
Fix yuv_full_range 1 => true
joeyparrish May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packager/media/codecs/vp9_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ bool ReadBitDepthAndColorSpace(BitReader* reader,
}
} else {
// Assume 4:4:4 for colorspace SRGB.
yuv_full_range = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it's a bool, so yuv_full_range = true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

chroma_subsampling = VPCodecConfigurationRecord::CHROMA_444;
if (codec_config->profile() & 1) {
bool reserved;
Expand Down
Loading