fix: Embed full python protobuf library #1438
Merged
+72
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This embeds the full python protobuf library into the output in pssh-box-protos, which is used by installation targets and Docker images. Without this, the installed pssh-box.py tool would depend on a separate installation of the python protobuf library. Closes shaka-project#1436
|
@emarsden FYI You can preview the fix at docker.io/joeyparrish/shaka-packager:fixed-pssh-box-deps-pr-1438 |
cosmin
approved these changes
Oct 2, 2024
cosmin
pushed a commit
that referenced
this pull request
Oct 24, 2024
🤖 I have created a release *beep* *boop* --- ## [3.2.1](v3.2.0...v3.2.1) (2024-10-02) ### Bug Fixes * Add Missing Dash Roles to RoleFromString function ([#1418](#1418)) ([#1419](#1419)) ([9cb00e9](9cb00e9)) * Break header installation for the shared library ([#1407](#1407)) ([b5c2cb8](b5c2cb8)), closes [#1406](#1406) * Embed full python protobuf library ([#1438](#1438)) ([f07fd0d](f07fd0d)), closes [#1436](#1436) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This embeds the full python protobuf library into the output in pssh-box-protos, which is used by installation targets and Docker images. Without this, the installed pssh-box.py tool would depend on a separate installation of the python protobuf library.
Closes #1436