Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I tried to compile and pass all the tests, but one failing test caught my eye:
It reminds me of the signed zero in IEEE 754, which indicates the sign of a zero, regardless of the fact that
0.0 == -0.0
. Therefore, a directto_string()
will make the test fail if the test case constructs-0.0
deliberately.This patch passes the test by additionally judging whether the number to be returned equals zero. Since
0.0 == -0.0
, both should be treated as0.0
when printing.It's is a tiny patch and only takes perhaps less than a minute to check and comment. The library is great, I find it handy. Thanks, and have a nice day / night : )