Skip to content

Fix e2e failures by declaring the e2e registry as insecure for buildpacks builds - #407

Merged
openshift-merge-bot[bot] merged 1 commit into
shipwright-io:mainfrom
IrvingMg:fix/e2e-output-insecure
Aug 24, 2026
Merged

Fix e2e failures by declaring the e2e registry as insecure for buildpacks builds#407
openshift-merge-bot[bot] merged 1 commit into
shipwright-io:mainfrom
IrvingMg:fix/e2e-output-insecure

Conversation

@IrvingMg

@IrvingMg IrvingMg commented Aug 23, 2026

Copy link
Copy Markdown
Member

Changes

The e2e tests push to the in-cluster registry (registry.registry.svc.cluster.local:32222) over plain HTTP. Since 2026-08-22 the buildpacks-v3 sample strategy's paketobuildpacks/builder-jammy-full:latest image ships CNB lifecycle 0.21.17, which no longer falls back to HTTP for non-localhost registries unless they are listed in CNB_INSECURE_REGISTRIES. The strategy only sets that when the Build declares its output as insecure, so every buildpacks build in e2e now fails with:

failed to initialize analyzer: validating registry read access: ... http: server gave HTTP response to HTTPS client

This adds --output-insecure=true to the shp build create calls in the tests that build against that registry (buildrun-gather, log-follow-F, log-follow--follow, run-follow, upload), matching what upload with bundle already does.

Verified on a local kind cluster: the 5 tests that fail in CI (gather, logs follow x2, build run follow, build upload) all pass with this change.

Related upstream: shipwright-io/build#2301 (pin the builder image) / shipwright-io/build#2302.

This PR was assisted by Claude.

Type of PR

/kind cleanup

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Kind label has been set
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

The e2e tests push to the in-cluster registry over plain HTTP. Newer
Paketo builder images (0.3.644, CNB lifecycle 0.21.17) no longer fall
back to HTTP for non-localhost registries unless they are listed in
CNB_INSECURE_REGISTRIES, which the buildpacks-v3 strategy only sets when
the Build declares its output as insecure. Pass --output-insecure=true
in the tests that build against that registry.

Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
@pull-request-size pull-request-size Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 23, 2026
@openshift-ci openshift-ci Bot added release-note-none kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 23, 2026
@IrvingMg IrvingMg changed the title Declare the e2e registry as insecure for buildpacks builds Fix e2e failures by declaring the e2e registry as insecure for buildpacks builds Aug 23, 2026
@IrvingMg

Copy link
Copy Markdown
Member Author

PR to fix Release Note Linter check: #406

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2026
@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 1577429 into shipwright-io:main Aug 24, 2026
11 of 12 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Issues Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants