Fix e2e failures by declaring the e2e registry as insecure for buildpacks builds - #407
Merged
openshift-merge-bot[bot] merged 1 commit intoAug 24, 2026
Conversation
The e2e tests push to the in-cluster registry over plain HTTP. Newer Paketo builder images (0.3.644, CNB lifecycle 0.21.17) no longer fall back to HTTP for non-localhost registries unless they are listed in CNB_INSECURE_REGISTRIES, which the buildpacks-v3 strategy only sets when the Build declares its output as insecure. Pass --output-insecure=true in the tests that build against that registry. Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
Member
Author
|
PR to fix Release Note Linter check: #406 |
4 tasks
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Aug 24, 2026
1577429
into
shipwright-io:main
11 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The e2e tests push to the in-cluster registry (
registry.registry.svc.cluster.local:32222) over plain HTTP. Since 2026-08-22 thebuildpacks-v3sample strategy'spaketobuildpacks/builder-jammy-full:latestimage ships CNB lifecycle 0.21.17, which no longer falls back to HTTP for non-localhost registries unless they are listed inCNB_INSECURE_REGISTRIES. The strategy only sets that when the Build declares its output as insecure, so every buildpacks build in e2e now fails with:This adds
--output-insecure=trueto theshp build createcalls in the tests that build against that registry (buildrun-gather,log-follow-F,log-follow--follow,run-follow,upload), matching whatupload with bundlealready does.Verified on a local kind cluster: the 5 tests that fail in CI (
gather,logs followx2,build run follow,build upload) all pass with this change.Related upstream: shipwright-io/build#2301 (pin the builder image) / shipwright-io/build#2302.
This PR was assisted by Claude.
Type of PR
/kind cleanup
Submitter Checklist
Release Notes