Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix blockchain question in FAQ #295

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

facutuesca
Copy link
Contributor

@facutuesca facutuesca commented Mar 5, 2024

Summary

Fixes #294. The current FAQ located here seems to have a question that does not match the answer:

image

This changes the question to what it was originally (see the linked issue for more details)
This now deletes the question, as per the discussion in the review comments

Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit fce6464
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/65e98869614420000821f204
😎 Deploy Preview https://deploy-preview-295--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -146,7 +146,7 @@ We would love that. The more people monitoring the logs and providing useful ser

There's no need for a distributed source of transparency as there can be multiple points of transparency which only adds more sources of security guarantee, not fewer. An entity can post to as many Rekor logs as they want and inform users of where they post. We do encourage folks to use common public instances, but we don't seek to enforce this. We do plan to look to produce a gossip protocol, for those that desire a more decentralised model (if there's demand).

### How do I verify downloaded code?
### Why not use a blockchain?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, what do you think about deleting this section entirely? It's a good discussion topic, but it's quite technical for an FAQ and I think the answer here is a bit too concise and maybe even a bit inaccurate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, we can always re-add it later if necessary

Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
@haydentherapper
Copy link
Contributor

cc @bobcallaway @ltagliaferri for merge

@ltagliaferri ltagliaferri merged commit b84a942 into sigstore:main Mar 11, 2024
6 checks passed
@facutuesca facutuesca deleted the faq-fix-question branch March 11, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question in the FAQ has incorrect title
4 participants