-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make masterFilename what it says on the tin #1835
Make masterFilename what it says on the tin #1835
Conversation
Process the basename when that's specifically what we need rather than making it a basename initially and not having the extension information when we need it.
0d5c178
to
759131e
Compare
Somehow makes sense, though breaking an internal compatibility might be best in 0.15 rather than 0.14.x... (Especially for something that should occur that often) This will break too on my side of things. Hoping this quick check caught them all:
Those using the directory where is located the master file should be safe, so I assume the list of impacts is a bit smaller:
... And adding |
What if we left |
That's extra work later for 3rd party package maintainers.
Later, 0.15 or even beyond, we remove the old SILE.masterFilename without extension, so it gets nil. In the meantime, 3rd party packages can start replacing Or something similar? |
Okay I'll leave Where and how we name intermediary files needs a bigger overhaul anyway. It really should be possible to use a cache dir somewhere separate from sources OR outputs, and right now that isn't really possible. |
Closes #1833.
As far as SILE itself is concerned this shouldn't be noticed, but that's not to say documents or other project code that generates files and assumes that
masterFilename
is a basename not a file name won't be affected. I had in mind to put this in the next breaking release just to be safe, but given the current situation I'm not sure adding more hacks to work around this silly problem in the short term knowing we want to fix it properly anyway makes sense either.This will break CaSILE but I'll fix that. I don't know if any other 3rd party extensions will be affected.
@Omikhleia does this change make sense to you?