Consolodate locale related resources in language scope #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
force-pushed
the
integrate-i18n
branch
from
ce69715
to
f481205
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on #2102 where we reorganized the language directory a little bit to logically accommodate more than one Lua file per locale my making each locale a directory. There isn't really any compelling reason these need to be in their own scope. It's theoretically possible this would break 3rd party modules that have completely overridden a locale by providing an alternative load path with higher priority, but in all the usage I am aware up (mostly my own) only select messages are being overridden by loading an additional module, not totally blocking the original.