Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(math): Fractions must have padding to avoid visual confusion #2142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Omikhleia
Copy link
Member

MathML Core 3.3.2: "To avoid visual confusion between the fraction bar and another adjacent items (e.g. minus sign or another fraction's bar)"

Closes #1801

MathML Core 3.3.2: "To avoid visual confusion between the fraction bar
and another adjacent items (e.g. minus sign or another fraction's bar)"
@Omikhleia Omikhleia added the bug Software bug issue label Oct 19, 2024
@Omikhleia Omikhleia added this to the v0.15.6 milestone Oct 19, 2024
@Omikhleia Omikhleia self-assigned this Oct 19, 2024
@Omikhleia Omikhleia requested a review from a team as a code owner October 19, 2024 18:18
@Omikhleia
Copy link
Member Author

Impacted tests:

  • tests/math-bigops.xml
  • tests/math-fractions.xml
  • tests/math-macros.sil
  • tests/math-stretchy.xml

--> Checking them atm.

@Omikhleia
Copy link
Member Author

--> Checking them atm.

They all look good to me, the small extra padding is not too visible but fixes the issue:
For the record tests/math-fractions.xml experienced it, in its last test, i.e.

<math>
  \frac{i+1}{}
  \frac{}{i+1}
</math>

This was producing a single long continuous fraction bar.
Which might have been the wanted effect here? But this is not the correct way to handle alignments anyway, and would have been confusing without empty denominator/numerator...

Before/After:
image

Now I'd need to push the fixed test expectations.... And still don't have the correct version of Gentium(?) in my dockers...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software bug issue
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Consecutive math fractions are too close
1 participant