Remove redundant log message from $user->updateExternalGroups()

silinternational · Sep 4, 2024 · ca040ad · ca040ad
1 parent cbc532f
commit ca040ad
Showing 1 changed file with 1 addition and 11 deletions.
diff --git a/application/common/models/User.php b/application/common/models/User.php
@@ -1094,17 +1094,7 @@ public function updateExternalGroups(string $appPrefix, string $csvAppExternalGr
         $this->addInMemoryExternalGroups($appExternalGroups);
 
         $this->scenario = self::SCENARIO_UPDATE_USER;
-        $saved = $this->save(true, ['groups_external']);
-        if ($saved) {
-            return true;
-        } else {
-            Yii::warning(sprintf(
-                'Failed to update external groups for %s: %s',
-                $this->email,
-                join(', ', $this->getFirstErrors())
-            ));
-            return false;
-        }
+        return $this->save(true, ['groups_external']);
     }
 
     /**