Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IDP-1183] Specify jsonAuthString for each external-groups sync set #362

Merged
merged 6 commits into from
Sep 10, 2024
Merged

[IDP-1183] Specify jsonAuthString for each external-groups sync set #362

merged 6 commits into from
Sep 10, 2024

Conversation

forevermatt
Copy link
Contributor

@forevermatt forevermatt commented Sep 9, 2024 •
edited
Loading

IDP-1183 Sync prefixed-groups from Google Sheet to ID Broker's groups_external field

Added

  • Pass in jsonAuthString (for external-groups sync) via env. var. as well

Changed (non-breaking)

  • Move webmozart/assert from dev to normal dependency

Fixed

  • Fix empty-value data type in ExternalGroupsSync::syncAllSets()
  • Provide a better error message re: missing Google Sheets tab for external-groups sync
  • Update dependencies

Feature PR Checklist

  • Documentation (README, local.env.dist, api.raml, etc.)
  • Tests created or updated
  • Run make composershow
  • Run make psr2

@forevermatt forevermatt requested a review from a team September 9, 2024 20:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@briskt briskt requested a review from a team September 10, 2024 01:05
@forevermatt forevermatt merged commit 6389c5b into develop Sep 10, 2024
3 checks passed
@forevermatt forevermatt deleted the feature/IDP-1183-set-jsonAuthString branch September 10, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forevermatt @briskt