Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic for sync-errors email for when the Google Sheet ID isn't known #376

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix logic for sync-errors email for when the Google Sheet ID isn't known #376

merged 1 commit into from
Oct 7, 2024

Conversation

forevermatt
Copy link
Contributor

IDP-1221 Send error notification email for external-groups sync errors

Fixed

  • Fix logic for sync-errors email for when the Google Sheet ID isn't known

Feature PR Checklist

  • Run make composershow
  • Run make psr2

@forevermatt forevermatt requested a review from a team as a code owner October 2, 2024 15:28
@forevermatt forevermatt requested review from briskt, mtompset, jason-jackson and hobbitronics and removed request for a team October 2, 2024 15:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@forevermatt forevermatt mentioned this pull request Oct 2, 2024
Merged
4 tasks
@forevermatt forevermatt merged commit 1d37409 into develop Oct 7, 2024
3 checks passed
@forevermatt forevermatt deleted the feature/idp-1221-email-content-bugfix branch October 7, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forevermatt @briskt