[IDP-1221] Add documentation, improve logging, do some cleanup #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forevermatt
requested review from
briskt,
mtompset,
jason-jackson and
hobbitronics
and removed request for
a team
jason-jackson
approved these changes
Oct 7, 2024
briskt
approved these changes
Oct 7, 2024
| - `EXTERNAL_GROUPS_SYNC_set1ErrorsEmailRecipient` | ||
| - Set this to a single email address. | ||
| 10. If you need to sync those custom groups to another IDP... | ||
| - Ensure that IDP is also running a recent enough version of ID Broker. |
There was a problem hiding this comment.
Suggested change
| - Ensure that IDP is also running a recent enough version of ID Broker. | |
| - Ensure that IDP is also running ID Broker version 6.8.0 or later. |
There was a problem hiding this comment.
Since I mentioned a specific version further up, I didn't want to duplicate that here (e.g. in case we later update the minimum version needed in one place and forget to update it in the other).
forevermatt
commented
Oct 8, 2024
Co-authored-by: briskt <3172830+briskt@users.noreply.github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDP-1221 Send error notification email for external-groups sync errors
Added
groups_externalvalues during a synclocal.env.dist) how to format Google JSON key for env. var.Fixed
Emailer->email()Exceptionclass usage inEmailLog::logMessage()Feature PR Checklist
make composershowmake psr2