Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 6.10.0 - Enable external-group sync-errors email notification #378

Merged
merged 29 commits into from
Oct 9, 2024
Merged

Release 6.10.0 - Enable external-group sync-errors email notification #378

merged 29 commits into from
Oct 9, 2024

Conversation

forevermatt
Copy link
Contributor

IDP-1221 Send error notification email for external-groups sync errors

Added

  • Document (in README) how to set up external-groups syncs from a Google Sheet
  • Enable (optionally) sending an email notification if there are any external-groups sync errors
  • Log actual changes to Users' groups_external values during a sync
  • Document (in local.env.dist) how to format Google JSON key for env. var.

Changed (non-breaking)

  • Enable the Emailer to send to an arbitrary email address

Fixed

  • Update dependencies
  • Fix parameter data type in PHP DocBlock on Emailer->email()
  • Fix incorrect Exception class usage in EmailLog::logMessage()

Feature PR Checklist

  • Documentation (README, local.env.dist, api.raml, etc.)
  • Tests created or updated
  • Run make composershow
  • Run make psr2

forevermatt and others added 29 commits September 11, 2024 16:39
@forevermatt
Add test for sync-error notification emails
8dda42a
@forevermatt
Add subject for sync-errors email to Emailer class
41cbac5
@forevermatt
Merge branch 'develop' into feature/IDP-1221-sync-errors-notification…
ced1394 
…-email
@forevermatt
Merge branch 'develop' into feature/IDP-1221-sync-errors-notification…
7a39a94 
…-email

# Conflicts:
#	application/features/groups-external-sync.feature
@forevermatt
Enable test and live code to use shared code for processing sync errors
efb4c85
@forevermatt
Rename external-group sync error variables/constants, for clarity
f5d9f04
@forevermatt
Tweak the subject used for external-group sync error emails
1059591
@forevermatt
Add EmailLog::MESSAGE_TYPE_EXT_GROUP_SYNC_ERRORS for sync-error emails
3c533d4
@forevermatt
Enable the Emailer to send to an arbitrary email address
19ff3a7
@forevermatt
Optionally send an external-groups sync-errors email notification
dc801b5
@forevermatt
Raise minimum PHP version to 8.0 (and update dependencies)
0a142ee
@forevermatt
Clarify purpose of Google Sheet ID parameter used for sync-error email
4703e72
@forevermatt
Add line to sync-error email about partial-successes
14e31fa
@forevermatt
Document the new errors-email-recipient env. vars (in local.env.dist)
27a7b68
@forevermatt
Fix PSR-2 formatting issue
8a5af26
@forevermatt
Fix test-safety-net to work for GitHub Actions' tests, too
8976497
@forevermatt
Re-add PHP 7.4 compatibility
aee1705
@forevermatt
Merge pull request #375 from silinternational/feature/IDP-1221-sync-e…
3391eae 
…rrors-notification-email

[IDP-1221] Optionally send external-groups sync-errors notification email
@forevermatt
Fix logic for sync-errors email for when the Google Sheet ID isn't known
33a7181
@forevermatt
Merge pull request #376 from silinternational/feature/idp-1221-email-…
1d37409 
…content-bugfix

Fix logic for sync-errors email for when the Google Sheet ID isn't known
@forevermatt
Document how to format Google JSON key for env. var.
afd5ead
@forevermatt
Fix parameter data type in PHP DocBlock on Emailer->email()
ab705c6
@forevermatt
Fix incorrect Exception class usage in EmailLog::logMessage()
e66a724
@forevermatt
Document (in README) basics of syncing external groups from Google Sheet
0f0cde3
@forevermatt
Log actual changes to Users' groups_external values during a sync
d670654
@forevermatt
Add more detailed documentation on how to set up external-groups syncs
b73ed74
@forevermatt
Reduce the severity level of external-group change-details log messages
113f006
@forevermatt @briskt
Improve external-sync documentation in README, per PR feedback
33b34df 
Co-authored-by: briskt <3172830+briskt@users.noreply.github.com>
@forevermatt
Merge pull request #377 from silinternational/feature/idp-1221-cleanu…
176b911 
…p-and-documentation

[IDP-1221] Add documentation, improve logging, do some cleanup
@forevermatt forevermatt requested a review from a team as a code owner October 8, 2024 18:49
@forevermatt forevermatt requested review from briskt, mtompset, jason-jackson and hobbitronics and removed request for a team October 8, 2024 18:49
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@forevermatt forevermatt merged commit 1e83429 into main Oct 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forevermatt @briskt