Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.2.1 - Wait for certificate validation #5

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Conversation

forevermatt
Copy link
Contributor

Fixed

  • Always have an aws_acm_certificate_validation resource
    • This is how we can depend on / know when the certificate has been validated and issued.
  • Get the certificate ARN from the validation resource
    • The validation resource's certificate ARN is available once the certificate has been issued:

      The aws_api_gateway_domain_name resource expects dependency on the aws_acm_certificate_validation as only verified certificates can be used. This can be made either explicitly by adding the depends_on = [aws_acm_certificate_validation.cert] attribute. Or implicitly by referring certificate ARN from the validation resource where it will be available after the resource creation: regional_certificate_arn = aws_acm_certificate_validation.cert.certificate_arn.
      (source)

    • Note that we are using this as the resource name, rather than cert as used in that documentation snippet.

forevermatt and others added 3 commits August 1, 2023 10:40
This is how we can depend on / know when the certificate has been
validated and issued.
The validation resource's certificate ARN is available once the
certificate has been issued.
@forevermatt forevermatt requested a review from a team August 2, 2023 20:12
@forevermatt forevermatt merged commit 210f3e6 into main Aug 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants