Skip to content

Commit

Permalink
Merge pull request #2 from silinternational/develop
Browse files Browse the repository at this point in the history
removed availability_zones from aws/asg to resolve bug with terraform…
  • Loading branch information
fillup authored Sep 28, 2017
2 parents ab697e7 + 5cac5af commit e38a268
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 13 deletions.
2 changes: 0 additions & 2 deletions aws/asg/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ an auto scaling group that uses the configuration.
- `app_env` - Name of environment, ex: production, testing, etc.
- `ami_id` - ID for AMI to be used.
- `aws_instance` - A map containing keys for `instance_type`, `volume_size`, `instance_count`
- `aws_zones` - A list of availability zones to distribute instances across
- `private_subnet_ids` - A list of private subnet ids to identify VPC subnets for placement
- `default_sg_id` - VPC default security group ID to add instances to
- `ecs_instance_profile_id` - IAM profile ID for ecsInstanceProfile
Expand All @@ -34,7 +33,6 @@ module "asg" {
app_name = "${var.app_name}"
app_env = "${var.app_env}"
aws_instance = "${var.aws_instance}"
aws_zones = "${var.aws_zones}"
private_subnet_ids = ["${module.vpc.private_subnet_ids}"]
default_sg_id = "${module.vpc.vpc_default_sg_id}"
ecs_instance_profile_id = "${module.ecs.ecs_instance_profile_id}"
Expand Down
1 change: 0 additions & 1 deletion aws/asg/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ resource "aws_launch_configuration" "as_conf" {
*/
resource "aws_autoscaling_group" "asg" {
name = "asg-${var.app_name}-${var.app_env}-${aws_launch_configuration.as_conf.name}"
availability_zones = "${var.aws_zones}"
vpc_zone_identifier = ["${var.private_subnet_ids}"]
min_size = "${var.aws_instance["instance_count"]}"
max_size = "${var.aws_instance["instance_count"]}"
Expand Down
10 changes: 0 additions & 10 deletions aws/asg/vars.tf
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,6 @@ variable "aws_instance" {
}
}

variable "aws_zones" {
type = "list"

default = [
"us-east-1c",
"us-east-1d",
"us-east-1e",
]
}

variable "private_subnet_ids" {
type = "list"
}
Expand Down

0 comments on commit e38a268

Please sign in to comment.