Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have callApi return an error instead of panic #74

Merged
merged 3 commits into from
May 21, 2024
Merged

have callApi return an error instead of panic #74

merged 3 commits into from
May 21, 2024

Conversation

jason-jackson
Copy link
Contributor

Changed

  • CallApi returns an error instead of panic

Removed

  • Deleted commented out code

@jason-jackson jason-jackson requested a review from a team April 29, 2024 18:45
hobbitronics
hobbitronics approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@briskt
Copy link
Contributor

briskt commented May 16, 2024

@jason-jackson is it ok to merge this?

@jason-jackson jason-jackson merged commit 9f350ed into release/v4.0.0 May 21, 2024
3 checks passed
@jason-jackson jason-jackson deleted the feature/call-api-return-error branch May 21, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@hobbitronics hobbitronics hobbitronics approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jason-jackson @briskt @hobbitronics