FIX Ensure changelog passes linting #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/master/lint-friendly-changelog
branch
from
aa6f5c9
to
9185510
Compare
GuySartorelli
force-pushed
the
pulls/master/lint-friendly-changelog
branch
from
9185510
to
87ef34b
Compare
2 tasks
GuySartorelli
force-pushed
the
pulls/master/lint-friendly-changelog
branch
from
87ef34b
to
3de09ba
Compare
emteknetnz
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested this with a dummy run and it works well.
Some commit messages may still introduce unexpected linting issues - we can look at whether the current set of rule exclusions is appropriate if/when that happens, but for now those rules are the only ones that need excluding. I don't want to exclude linting altogether for them in case some commit message has something which would result in poorly rendered markdown.
Issue