Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Create GitHub Action for adding PRs to the new project #1

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

GuySartorelli
Copy link
Member

This action follows the docs for using GitHub Actions to add PRs to a project.

There is a GitHub App which holds read-only access for issues and PRs, and write access to projects. This action uses that app to generate a token, then uses the official GitHub Action for adding PRs to the project.

We are explicitly ignoring PRs created by the CMS Squad, because the project board is for community contributions. We don't want to waste community time reviewing and merging the CMS Squad PRs when we're already being paid to do that ourselves.

Issue

action.yml Outdated
Comment on lines 29 to 30
app-id: ${{ vars.PROJECT_MANAGER_APP_ID }}
private-key: ${{ secrets.PROJECT_MANAGER_PRIVATE_KEY }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are stored in the silverstripe org.

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add in the workflow files that would eventually get added by module-standardiser, in particular auto-tag.yml

action.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
action.yml Show resolved Hide resolved
action.yml Show resolved Hide resolved
@GuySartorelli
Copy link
Member Author

GuySartorelli commented Jun 13, 2024

You should add in the workflow files that would eventually get added by module-standardiser, in particular auto-tag.yml

There is a PR to add this repo to standardiser. I'll run standardiser against it after all PRs are merged (I have to run it anyway to get the new action on all relevant repos)

README.md Show resolved Hide resolved
README.md Outdated

**.github/workflows/add-pr-to-project.yml**
```yml
name: Add pull request to project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Add pull request to project
name: Add new pull requests to a github project

Get it to match module-standardiser pr

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated
if: github.repository_owner == 'silverstripe'
runs-on: ubuntu-latest
steps:
- name: Add PR to project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Add PR to project
- name: Add PR to github project

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@emteknetnz emteknetnz merged commit 1bab9b1 into silverstripe:1 Jun 14, 2024
@emteknetnz emteknetnz deleted the pulls/1/new-action branch June 14, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants