FIX Remove broken code to copy diff files to artifacts #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2024
Open
emteknetnz
force-pushed
the
pulls/1.1/ignore-admin-js
branch
from
9615aad
to
e0136bc
Compare
|
The git diff check is really there to avoid malicious actors from manually injecting payloads into dist files. Given we aren't going to accept any PRs from anyone outside the CMS Squad for CMS 4 due to the current support level, this concept seems fine. |
emteknetnz
force-pushed
the
pulls/1.1/ignore-admin-js
branch
2 times, most recently
from
8743907
to
b3d4b59
Compare
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/1.1/ignore-admin-js
branch
from
b3d4b59
to
b66cec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#235
This PR deletes the "copy dist file that was different to artifacts dir" functionality that doesn't actually work, and instead just sends exit code 2.